binary_cache_secret_key_file still used
Nobody has claimed this yet.
- Dominant language
- PLpgSQL
- Stars
- 1.6k
- Forks
- 358
- Avg merge
- 20h 30m
- Merged PRs (30d)
- 27
Description
Although a warning is generated here https://github.com/NixOS/hydra/commit/7089142fdc06cad0765ec5ad69464c15a1ed2304, it seems that the binary_cache_secret_key_file is still needed here https://github.com/NixOS/hydra/blob/master/src/lib/Hydra/View/NARInfo.pm#L37. I'm unsure of the higher-level direction of changes involved, so I'm simply reporting this instead of submitting a PR.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the warning introduced in commit 7089142fdc06cad0765ec5ad69464c15a1ed2304 with the use of binary_cache_secret_key_file at src/lib/Hydra/View/NARInfo.pm line 37. Trace how that setting reaches NARInfo and determine the intended higher-level change; done means the deprecated setting is handled consistently without breaking binary-cache responses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100