Backwards compatibility problems with binary_cache_secret_key_file
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- perl
- Domain
- build-system
Research direction
Start by reading the deprecation warning in src/hydra-queue-runner/hydra-queue-runner.cc at the referenced lines, then trace the Perl configuration handling for binary_cache_secret_key_file, binary_cache_dir, and store_uri. Reproduce the local-store setup from the issue and verify that the redundant settings are no longer required while binary-cache configuration remains functional.
Written by the indexing model from the issue text.
Description
Using hydra with a binary_cache_secret_key_file and a local store used to only require that config.
The deprecation warnings in https://github.com/NixOS/hydra/blob/de55303197d997c4fc5503b52b1321ae9528583d/src/hydra-queue-runner/hydra-queue-runner.cc#L53-L60 specify that only store_uri is necessary.
The perl code still uses the old settings and now the required config is redundant in a few places:
store_uri = file:///var/lib/hydra/cache?secret-key=/etc/binary-cache.secret
binary_cache_secret_key_file = /etc/binary-cache.secret
binary_cache_dir = /var/lib/hydra/cache
cc @fpletz, @fadenb and commiter @groxxda
- Dominant language
- PLpgSQL
- Stars
- 1.6k
- Forks
- 358
- Avg merge
- 20h 30m
- Merged PRs (30d)
- 27
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from NixOS/hydra
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Similar issues
-
Needs Design Priority: Wishlist
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
elementary/flatpak-platform#253 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
objectionary/hone-maven-plugin#1060 ·
-
0.kind: build failure
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Update Vish to 1.1.5 Openpackage-update
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oSoWoSo/vOid_Community_repOsitory#144 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100