NixOS / NixOS/amis

smoke_test: --cancel still tries to launch an instance?

Open
#239 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
84
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Hm. --cancel doesn't really behave the way I'd expect. The codepath around it seem to ... still try to boot an instance, rather than short-circuiting to the cancellation as I was expecting to see.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the smoke_test entry point and its --cancel code path to identify where instance launch is initiated. Confirm the cancellation path short-circuits before launching an instance, then verify the behavior with the relevant smoke test or a focused regression check.

Written by the indexing model from the issue text.

Assessment

Tech stack
nixos, python
Domain
cloud, devops, infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.