base.njk nav element missing container class

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Open base.njk and locate the nav element currently using the nav class. Update the rendered navigation so it includes the container class, then verify the generated site uses both classes and the nav content is constrained and centered.

Written by the indexing model from the issue text.

Description

Problem

The base.njk template wraps the nav in:

<nav class="nav">

But the dart_node site uses:

<nav class="nav container">

The container class is needed for proper max-width and centering. Without it, the nav content stretches to full viewport width.

Suggestion

Add container to the nav class list, or provide a configurable wrapper class.

Dominant language
JavaScript
Stars
0
Forks
0
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Nimblesite/eleventy-plugin-techdoc

All issues in Nimblesite/eleventy-plugin-techdoc

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.