Nimblesite / Nimblesite/SharpLsp
Release: publish the two sidecar dotnet tool packages to NuGet
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 132
- Forks
- 5
- Avg merge
- 6h 24m
- Merged PRs (30d)
- 27
Description
docs/specs/BINARY-DEPLOYMENT.md describes distributing the C# and F# sidecars as dotnet tool packages, and the sidecar resolution order in src/sharplsp/src/sidecar/manager.rs puts a dotnet tool shim on PATH first — ahead of every bundled layout:
1. sharplsp-sidecar-csharp on PATH <- "the production distribution path"
2. installed layouts (VSIX / archive / dev)
3. dotnet run --project (dev only)
Nothing publishes those packages. ci-build.yml runs a dotnet pack smoke test, so the projects are known to pack; no job pushes them to nuget.org. docs/plans/DISTRIBUTION-PLAN.md had pack-sidecars and the NuGet publish ticked as done; both have been corrected to [ ] NOT BUILT.
This is not blocking anyone today — the VSIX and the new standalone server archive both ship the sidecars and resolve them by layout — but the code comment calling PATH "the production distribution path" is currently false, and the spec should either be built or amended.
Remaining work:
- Decide whether
dotnet tooldistribution is still the intended path, or whether[BINARY-DEPLOYMENT]should be narrowed to the archive + package managers - If keeping it: add a
pack-sidecarsjob torelease.ymland push both nupkgs with a NuGet API key on thereleaseenvironment ([DIST-SECRETS]) - Either way, correct the resolution-order comment in
manager.rsso it describes what actually ships
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with docs/specs/BINARY-DEPLOYMENT.md and docs/plans/DISTRIBUTION-PLAN.md to resolve whether dotnet tool distribution remains intended. If it does, inspect ci-build.yml and release.yml for the existing pack flow and release environment, then update src/sharplsp/src/sidecar/manager.rs. Done means the distribution docs, publish workflow, package handling, and resolution-order comment agree with what ships.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, rust
- Domain
- ci-cd, devops, release
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100