Nimblesite / Nimblesite/SharpLsp
Sidecar shutdown acknowledgement is never sent — handler cancels the token the response write depends on
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 132
- Forks
- 5
- Avg merge
- 6h 24m
- Merged PRs (30d)
- 27
Description
From the multi-agent audit (sidecars/SharpLsp.Sidecar.Common/SidecarHost.cs ~213): the shutdown handler cancels the host CancellationToken that the pending response write itself depends on, so the shutdown ack never reaches the host — the host's graceful path always times out (1s) before the hard kill. Write the ack first (flush), then cancel.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sidecars/SharpLsp.Sidecar.Common/SidecarHost.cs around line 213 and inspect the shutdown handler and its response-writing path. Verify that the acknowledgement is flushed before host cancellation, then confirm the host’s graceful shutdown receives the acknowledgement instead of timing out before the hard kill.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100