Nimblesite / Nimblesite/SharpLsp

Sidecar solution restore broken: MessagePack 3.1.7/3.1.8 downgrade + FSharp.Core 10.1.301 violates FCS exact pin

Open
#155 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

.NET bug showstopper
Dominant language
TypeScript
Stars
132
Forks
5
Avg merge
6h 24m
Merged PRs (30d)
27

Description

dotnet restore sidecars/SharpLsp.Sidecars.sln currently fails:

  • NU1605 (×2): SharpLsp.Sidecar.CSharp and SharpLsp.Sidecar.CSharp.Tests pin MessagePack 3.1.7, but they reference SharpLsp.Sidecar.Common, which pins 3.1.8 — a package downgrade along a project-reference edge, elevated to error.
  • NU1608 (×2): SharpLsp.Sidecar.FSharp and SharpLsp.Sidecar.FSharp.Tests pin FSharp.Core 10.1.301, but FSharp.Compiler.Service 43.12.204 requires exactly FSharp.Core 10.1.204. 43.12.204 is the latest stable FCS on NuGet, so there is no forward bump available — the FSharp.Core pin must match FCS.

Root cause: a partial dependency bump updated MessagePack in Common/FSharp and FSharp.Core in the F# projects without propagating to the C# projects or checking the FCS exact-pin constraint. This blocks building/testing the full sidecar solution.

Fix: align MessagePack to 3.1.8 everywhere; pin FSharp.Core to 10.1.204 (matched pair with FCS 43.12.204). Regression guard: static dependency-consistency tests that fail on any project-reference downgrade (NU1605) and on FSharp.Core/FCS pair drift (NU1608).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the project files under sidecars/SharpLsp.Sidecars.sln and run dotnet restore sidecars/SharpLsp.Sidecars.sln to reproduce NU1605 and NU1608. Align MessagePack across the C# projects and FSharp.Core with FSharp.Compiler.Service, then add the described static dependency-consistency regression tests and verify restore and tests succeed.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
75/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.