NginxProxyManager / NginxProxyManager/nginx-proxy-manager

Certificate creation API returns 400 if `letsencrypt_agree` or `letsencrypt_email` are included — undocumented breaking change

Open
#5,696 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

As of v2.14.0, passing letsencrypt_agree or letsencrypt_email in the
POST /api/nginx/certificates request body causes a 400 with no descriptive
error message. These fields were accepted in prior versions and are still
referenced in community documentation and tooling.

Observed Impact: Cert creation failed with a generic 400 after upgrading,
with no indication which field is the problem.

Request:

  1. Add a note to the v2.14.0 release notes that these fields were removed.
  2. Return a descriptive error message naming the offending field rather than a
    generic 400.

Tested against v2.14.0.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the implementation of POST /api/nginx/certificates and the v2.14.0 release notes. Reproduce a request containing letsencrypt_agree or letsencrypt_email, then identify the validation path and documentation location. Done means the response names the offending field and the release notes state that these fields were removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
nginx, typescript
Domain
api, backend, documentation
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.