NginxProxyManager / NginxProxyManager/nginx-proxy-manager

Remove spaces from domain input

Open Beginner friendly
#5,654 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • Yes / No
  • Are you sure you're not using someone else's docker image?
    • Yes / No
  • Have you searched for similar issues (both open and closed)?
    • Yes / No

Describe the bug
When entering a new host on npm, ex. a domain or an ip, should you put a space before or after said host, it wont load at all and throw a 502 which is highly misleading (as its not related to upstream not responding).
The browser will forcefully remove every space on the domain/hostname so the browser guesses right.
It's about following the standard and avoiding confusion as someone would instinctively go check for upstream/docker errors.

A javascript check to remove spaces is presumably enough in my opinion.

Nginx Proxy Manager Version
latest (as per rn)
v2.15.1

To Reproduce
Steps to reproduce the behavior:
As mentioned above.

Expected behavior
502 Error.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by entering leading or trailing spaces in a new host's domain or IP field, then trace the frontend validation for that input. Confirm the intended behavior with the issue's description and verify that the entered host no longer causes a misleading 502 response.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.