NginxProxyManager / NginxProxyManager/nginx-proxy-manager

Allow nginx parameters *after* proxy.conf include

Open
#5,175 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement stale
Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

Is your feature request related to a problem? Please describe.
In a proxy scenario, occasionally we need to rewrite HTTP headers explicitly. For example I may host "mySite.proxy.company.com" and I want it to forward to an internal site "mySite-internal.company.com" . The server at "mySite-internal.company.com" does not respond/allow the CN of "mysite.proxy.company.com" and so it needs to be manually changed.

adding a line like this to the site conf file after the include /etc/nginx/conf.d/include/proxy.conf; line would allow or this:

proxy_set_header Host myHostName.myDomain;

Currently the Custom Nginx Configuration dialog only allows for custom configurations before the include of proxy.conf. Please add support for site-specific includes after proxy.conf as well.

Great job on this project by the way!!!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the Custom Nginx Configuration dialog is rendered into site configuration and where /etc/nginx/conf.d/include/proxy.conf is included. Check the configuration-generation path for a site-specific include after proxy.conf. Done means a custom directive such as proxy_set_header Host can be placed after the shared include for one site.

Written by the indexing model from the issue text.

Assessment

Tech stack
nginx, typescript
Domain
backend, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.