NginxProxyManager / NginxProxyManager/nginx-proxy-manager
aeb4424 broke my proxy manager instance (log.conf not found)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 34.2k
- Forks
- 3.9k
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 20
Description
I assume I'm not the only one who uses their own nginx.conf, a modified version of what's shipped with nginx-proxy-manager. aeb4424 broke my instance due to referencing a log config file called log-proxy.conf instead of log.conf which my older nginx.conf still expected.
I understand that this sometimes needs to be done. But renaming a file log.conf -> log-proxy.conf seems unnecessary, and not done with the spirit of minimal change in mind.
Though I may not be running a supported use case (shipping my own nginx.conf), I think its not unreasonable to ask to keep scenarios like this in mind for future pull requests.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit aeb4424 and the references to log.conf and log-proxy.conf in the shipped nginx.conf. Reproduce the failure with an older custom nginx.conf and check how the renamed file is referenced. Done means an older custom configuration no longer fails because log.conf is missing, while the current configuration continues to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100