NginxProxyManager / NginxProxyManager/nginx-proxy-manager
_locations.conf missing jinja2 variables?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 34.2k
- Forks
- 3.9k
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 20
Description
I ran into a wierd problem with custom location.
my webapp runs its own location like /login
so for npm to forward that corretly you need to set location to /help/ and proxy_pass ip:port/; trailing slash is important
then i stumbled upton the templates folder and _locations.conf uses proxy_pass {{ forward_scheme }}://{{ forward_host }}:{{ forward_port }}{{ forward_path }};
but {{ forward_path }} is nerver set anywhere so the final proxy_pass in nginxs .conf always ends in
proxy_pass http(s)://ip:port; and missing the trailing slash.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the templates/_locations.conf file mentioned in the issue and search the repository for forward_path to see how location proxy settings are defined. Done means custom locations generate proxy_pass with the required trailing slash when the configured path needs one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100