NginxProxyManager / NginxProxyManager/nginx-proxy-manager

Let's Encrypt Certificate fails if Propagation Seconds is set for Route53 DNS Challenge

Open
#4,702 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • Yes
  • Are you sure you're not using someone else's docker image?
    • Yes
  • Have you searched for similar issues (both open and closed)?
    • Yes

Describe the bug

I was trying to create a Let's Encrypt Certificate with DNS Challenge for Route53 and I noticed that if you set the parameter Propagation Seconds it fails with the following error

CommandError: usage: 
  certbot [SUBCOMMAND] [options] [-d DOMAIN] [-d DOMAIN] ...

Certbot can obtain and install HTTPS/TLS/SSL certificates.  By default,
it will attempt to use a webserver both for obtaining and installing the
certificate. 
certbot: error: unrecognized arguments: --dns-route53-propagation-seconds 60

    at /app/lib/utils.js:16:13
    at ChildProcess.exithandler (node:child_process:430:5)
    at ChildProcess.emit (node:events:524:28)
    at maybeClose (node:internal/child_process:1104:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)

Nginx Proxy Manager Version

v2.12.6

To Reproduce
Steps to reproduce the behavior:

  1. Go to SSL Certificates
  2. Click on Add SSL Certificate > Let's Encrypt
  3. Fill the form with DNS Challenge enabled
  4. Set Route53 for DNS provider
  5. Set any value for Propagation Seconds

Expected behavior

It seems that certbot deleted the parameter for propagation seconds in v3.0.0

The --dns-route53-propagation-seconds command line flag was removed.

Source: https://github.com/certbot/certbot/blob/f0f036a34c7f5187025171e3c39dd941f30e273c/certbot/CHANGELOG.md

Screenshots

Image

Operating System

Ubuntu 24

Additional context

N/A

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/utils.js from the reported stack trace and trace the Route53 DNS challenge arguments generated for certificate requests. Check how the Propagation Seconds value is passed to Certbot v3, then reproduce the issue with the documented steps. Done means the setting no longer causes an unrecognized-argument failure and the certificate request completes.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, typescript
Domain
backend, cloud, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.