NginxProxyManager / NginxProxyManager/nginx-proxy-manager

Disabling/Enabling a Proxy Host with an Access List results in 403 errors (none of the IPs are included in the generated proxy host conf file)

Open
#4,286 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug stale
Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • Yes
  • Are you sure you're not using someone else's docker image?
    • Yes
  • Have you searched for similar issues (both open and closed)?
    • Yes (4227 and 1279, but they are NOT the same as this issue)

Describe the bug
When you disable a Proxy Host that uses an Access List, and then re-enable the Proxy Host, the Access List is not applied and ALL requests are denied. It is as if the backend/templates/_access.conf file does process access lists, but somehow none of the IP addresses that were specified get through. Thus, the resulting nginx proxy host conf file practically only contains deny all; and hence all requests result in an HTTP 403 (Forbidden) error.

Nginx Proxy Manager Version
2.11.3 (I reverted to this one as some claimed it would have a fix, but the issue still applies)

To Reproduce
Steps to reproduce the behavior:

  1. Create a Proxy Host and apply an Access List.
  2. Then Disable the Proxy Host.
  3. Then Enable the Proxy Host again.
  4. Look at the resulting proxy_host/xxx.conf file that just got generated
  5. Notice that the proxy host conf file doesn't contain any of the IP addresses that you specified in the Access List.

Expected behavior
The IP addresses that you specified in the Access List should be included in the generated Proxy Host conf file.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with backend/templates/_access.conf and reproduce the disable/enable sequence from the issue. Inspect the generated proxy_host/xxx.conf file before and after re-enabling the host, then verify that the configured Access List IP addresses are present and allowed instead of only deny all; requests from those IPs should no longer return 403.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, nginx
Domain
infrastructure, networking, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.