NginxProxyManager / NginxProxyManager/nginx-proxy-manager

404 not working for SSL Default

Open
#4,255 8 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
34.2k
Forks
3.9k
Avg merge
21h 12m
Merged PRs (30d)
20

Description

Checklist

  • Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
    • No
  • Are you sure you're not using someone else's docker image?
    • Yes
  • Have you searched for similar issues (both open and closed)?
    • Yes

Describe the bug
I have installed the docker image of the latest NPM. I have manually added a wildcard SSL certificate. I have configured NPM to use a custom 404 error page. I have not yet created any hosts.
When I browse using HTTP to NPM i.e. http://site.domain.com, I correctly see my 404 page.
When I browse using HTTPS to NPM i.e. https://site.domain.com, I do not see my 404 page but instead see 'This site can't be reached' and 'ERR_SSL_UNRECOGNIZED_NAME_ALERT'.
Is there something else I need to configure in order for the 404 to work for SSL also?

Nginx Proxy Manager Version

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings, default site, edit, select custom and paste html
  2. Go to SSL certificate and add custom certificate.
  3. That is all, do nothing else
  4. Open browser and enter http address and will see 404 page
  5. Open browser and https address and will not see 404 but error ststed above.

Expected behavior
When browsing to a non existent HTTPS web address I see my 404 page.

Screenshots

Operating System
Docker Desktop on Windows Host

Additional context

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce from Settings > Default Site with a custom 404 page and custom wildcard SSL certificate, then compare HTTP and HTTPS requests with no hosts configured. Check the Docker image's HTTPS handling for unmatched hostnames and determine whether the expected result is the custom 404 page rather than ERR_SSL_UNRECOGNIZED_NAME_ALERT.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, nginx
Domain
infrastructure, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.