NginxProxyManager / NginxProxyManager/nginx-proxy-manager
trim whitespaces on forward domain/hostname/ip
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 34.2k
- Forks
- 3.9k
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 20
Description
I have had the problem several times now that we accidentally had a space in the domain name, which caused the routing to fail. It's unfortunately hard to spot and could actually be trimmed during input, couldn't it?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how forward domain, hostname, and IP values are accepted and used for routing. Reproduce the failure with leading or trailing spaces, then add coverage for the affected input path; done means those values are trimmed and routing succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100