NginxProxyManager / NginxProxyManager/nginx-proxy-manager
[Security bug] User name oracle
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 34.2k
- Forks
- 3.9k
- Avg merge
- 21h 12m
- Merged PRs (30d)
- 20
Description
Checklist
- Have you pulled and found the error with
jc21/nginx-proxy-manager:latestdocker image?- No
- Are you sure you're not using someone else's docker image?
- ?
- Have you searched for similar issues (both open and closed)?
- yes
Describe the bug
I am doing a pentest for a customer of mine and I spotted the failed login message No relevant user found which seemed like an oracle . As I couldn't believe this bad practices at least 15 years ago popped up in 2024 I was looking at the code in https://github.com/NginxProxyManager/nginx-proxy-manager/blob/master/backend/internal/token.js#L25 it unfortunately confirmed my suspicion. And there are also other hints which should be avoided in the source code.
See https://cwe.mitre.org/data/definitions/204.html, https://owasp.org/Top10/A07_2021-Identification_and_Authentication_Failures/
Nginx Proxy Manager Version
v2.11.1
To Reproduce
see above
Expected behavior
Don't show any hint whether user exists, password is wrong, account is locked or whatsoever, see https://cheatsheetseries.owasp.org/cheatsheets/Authentication_Cheat_Sheet.html#incorrect-and-correct-response-examples
I hope this full disclosure is fine as I couldn't find another way filing it. Last but not least as the code is public it's pretty obvious.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in backend/internal/token.js around line 25, where the reported login error is generated. Trace the responses for an unknown user, an incorrect password, and other account states mentioned in the issue. Done means the login response no longer reveals whether a username exists or why authentication failed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, javascript
- Domain
- authentication, backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100