NginxProxyManager / NginxProxyManager/docker-nginx-full
nging.conf user command with enviroment variable PUID
Open
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 108
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
When running npm with a custom user:
enviroment:
- PUID=1000
- PGID=1000
Warn occur when processing the nginx.conf file, and this warn is logged at fallback_error.log:
2023/10/02 19:47:29 [warn] 158#158: the "user" directive makes sense only if the master process runs with super-user privileges, ignored in /etc/nginx/nginx.conf:4
I think it would be a better solution to not include the user command in nginx.conf if you have defined the PUID environment variable.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating nginx.conf and checking how the PUID environment variable affects the user directive. Reproduce the warning with PUID=1000 and PGID=1000, then verify that the warning is absent when PUID is defined while the configuration still works as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, nginx
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100