NextCommerceCo / NextCommerceCo/spark

Merchant-state safety: settings_data.json doctrine and sold-out grid state

Open
#31 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
0
Forks
1
Avg merge
9h 52m
Merged PRs (30d)
18

Description

Problem: Spark's docs treat configs/settings_data.json as the defaults file but never warn that pushing it overwrites live merchant Theme Editor state, and a plain ntk push uploads it. Separately, sold-out products vanish from product grids entirely, so a curated grid can silently render fewer cards than configured with no explanation to the shopper or the merchant.

Evidence: docs/extending-spark.md:18-30 (no overwrite warning); partials/product_card.html:4 wraps the whole card in an availability check; docs/onboarding-claude-code-prompt.md exists but is untracked.

Done when:

  • Spark docs carry the same settings-safety contract as the next-theme-dev skill: never push settings_data.json by default; when merging settings, use the live file as the base.
  • Product cards render a sold-out state (badge or greyed card, configurable) instead of disappearing.
  • The onboarding prompt doc is committed or deliberately dropped.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with docs/extending-spark.md:18-30 and compare its settings guidance with the next-theme-dev skill contract. Inspect partials/product_card.html:4 to understand the current availability check, then decide how the sold-out state should be represented and how docs/onboarding-claude-code-prompt.md should be handled. Done means safe settings guidance, visible sold-out cards, and a deliberate outcome for the onboarding prompt.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.