NeuroTechX / NeuroTechX/moabb

Is this code redundant?

Open
#698 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.1k
Forks
264
Avg merge
1d 13m
Merged PRs (30d)
23

Description

https://github.com/NeuroTechX/moabb/blob/bea3ec0a44ef419cb9537f0eeeafd94d73d39478/moabb/evaluations/evaluations.py#L196

Image

moabb/evaluations/evaluations.py

The lines 187-196 don't return any and the parameters don't match those below—are these redundant code?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open moabb/evaluations/evaluations.py and inspect lines 187-196 alongside the following implementation, comparing their parameters and behavior. Confirm whether the earlier lines are unreachable or redundant; done means the redundancy is removed or the issue is closed with a clear explanation if the code is intentional.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.