default bandpass parameters
Open
Nobody has claimed this yet.
moabb
question
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 264
- Avg merge
- 1d 13m
- Merged PRs (30d)
- 23
Description
Is there any reason why the default bandpass values are 8 and 32?
In my opinion these should be None i.e. the default is to not use a filter at all.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at moabb/paradigms/motor_imagery.py#L291-L311 and trace how the default bandpass values 8 and 32 are used. Determine whether the defaults should remain or become None, using the issue's rationale as the decision point. Done means the default behavior is agreed and the corresponding change is made consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100