NeuroTechX / NeuroTechX/moabb

`nemar_subject_template` is not flexible enough. In BIDS, the subject label can be any string: https://bids-specification.readthedocs.io/en/stable/glossary.html#subject-entities

Open
#1,098 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.1k
Forks
264
Avg merge
1d 13m
Merged PRs (30d)
23

Description

nemar_subject_template is not flexible enough. In BIDS, the subject label can be any string: https://bids-specification.readthedocs.io/en/stable/glossary.html#subject-entities
Do we really need nemar_subject_template? Can't we so something smarter to automatically infer the mapping?
The simplest solution would be if subjects in moabb were also strings and not ints.

Originally posted by @PierreGtch in https://github.com/NeuroTechX/moabb/pull/1085#discussion_r3452117539

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the BIDS subject-entities glossary and locating the uses of nemar_subject_template in moabb. Determine whether arbitrary string subject labels can be supported or whether the template should be replaced with automatic mapping. Done should include a decided mapping approach and tests covering non-integer subject labels.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.