NeuroTechX / NeuroTechX/EEG-ExPy

Merge changes to the device abstraction ("EEG") class from my repo

Open
#43 7 comments 0 reactions 1 assignee View on GitHub

@ErikBjare is already working on this.

Since Dec 3, 2020.

bhg2020 enhancement
Dominant language
Python
Stars
575
Forks
153
Avg merge
6h 44m
Merged PRs (30d)
3

Description

My stuff is in: https://github.com/ErikBjare/thesis/blob/master/src/eegwatch/devices/

Includes a bunch of minor changes, including:

  • Added type annotations
  • Support for recording Muse PPG/ACC/GYRO streams
TODO
  • start/stop is different for Brainflow vs Muse devices, this should maybe be refactored, but at least be documented.
  • I've ran the black formatter on all my code, so merging would be easiest after similar formatting has been applied on the eeg-notebooks project (like in #30)
  • Needs a way to enable PPG/ACC/GYRO streams (without hardcoding)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.