NeuroTechX / NeuroTechX/EEG-ExPy
Legend items order when using diff_waveform in plot_conditions
Open
@tmorshed is already working on this.
Since Apr 6, 2023.
bug
EEG-ExPy
- Dominant language
- Python
- Stars
- 575
- Forks
- 153
- Avg merge
- 6h 44m
- Merged PRs (30d)
- 3
Description
ℹ Computer information
- Platform OS: Mac
- Python Version: 3.7
- Brain Interface Used: Muse
📝 Provide detailed reproduction steps (if any)
- Run
examples/visual_p300/01r__p300_viz.py
✔️ Expected result
I think is just changing order when concatenating lists in https://github.com/NeuroTechX/eeg-notebooks/blob/master/eegnb/analysis/utils.py#L307
Instead of:
legend = ["{} - {}".format(diff_waveform[1], diff_waveform[0])] + list(
conditions.keys()
)
could be something like:
legend = list(conditions.keys()) + ["{} - {}".format(diff_waveform[1], diff_waveform[0])]
❌ Actual result
📷 Screenshots
To check and identify wave forms and legend items, I compared with Alexandre's article in: http://alexandre.barachant.org/blog/2017/02/05/P300-with-muse.html
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.