NethermindEth / NethermindEth/pluto

Gate releases on the smoke-test suite

Open
#599 0 comments 0 reactions 1 assignee View on GitHub

@iamquang95 is already working on this.

Since Sep 15, 2026.

testing
Dominant language
Rust
Stars
8
Forks
5
Avg merge
4d 16h
Merged PRs (30d)
37

Description

Summary

The smoke suite (smoke-tests.yml) is workflow_dispatch-only — deliberately, since each scenario stands up a full docker-compose cluster and is too heavy for PRs. But the release path (publish-dockerhub.yml, triggered on pushes to main and v* tags) validates the image with nothing more than a -h output check before pushing to Docker Hub. A functionally broken image can ship.

Proposed change

Run the smoke suite automatically for releases and block publishing on it:

  • Convert smoke-tests.yml into a reusable workflow (workflow_call) and invoke it from publish-dockerhub.yml as a gate before the push-by-digest steps, at least for v* tags.
  • Pass the locally built image through (the smoke workflow currently rebuilds pluto:local itself) so the exact artifact being published is what gets tested.
  • Keep the very_large scenario excluded, as the manual workflow already does.

Acceptance

Pushing a v* tag runs the smoke scenarios against the image being published; a firing alert in any scenario fails the workflow and nothing is pushed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.