NethermindEth / NethermindEth/nethermind

Redownloading blocks in MergeBlockDownloader

Open
#4,792 4 comments 1 reaction 1 assignee View on GitHub

@asdacap is already working on this.

Since Jan 23, 2024.

performance is good
Dominant language
C#
Stars
1.6k
Forks
733
Avg merge
1d 17h
Merged PRs (30d)
476

Description

Even if we have blocks in db we're redowloading them in MergeBlockDownloader.
https://github.com/NethermindEth/nethermind/blob/master/src/Nethermind/Nethermind.Merge.Plugin/Synchronization/MergeBlockDownloader.cs#L161

If on BlockInfo we have Metadata.BeaconBlock we should be able to get block from db and not from the network

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.