NethermindEth / NethermindEth/juno
Remove CANDIDATE support for subscriptions
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 444
- Forks
- 244
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 78
Description
rpc/v{9,10}/subscription_transactions.go / subscription_types.go — "CANDIDATE" is still accepted by the subscription UnmarshalJSON but no longer wired to a handler; a client subscribing to CANDIDATE alone silently receives nothing. Reasonable given candidates no longer exist; consider rejecting the value or dropping the enum in a follow-up for clearer client feedback.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in rpc/v9/subscription_transactions.go and rpc/v10/subscription_transactions.go, then inspect the related subscription_types.go files and their UnmarshalJSON implementations. Trace how subscription values are registered with handlers and run the relevant Go tests. Done means CANDIDATE no longer silently produces an inactive subscription, with the chosen rejection or enum-removal behavior covered for both versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100