NethermindEth / NethermindEth/juno
genesis: `DeployAccount` transactions get a `nil` `ContractAddress` in `executeTransactions`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 444
- Forks
- 244
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 78
Description
DeployAccount transactions get a nil ContractAddress in genesis/genesis.go's executeTransactions (ref): the rpc.TxnDeployAccount branch sets ContractAddress: txn.SenderAddress, but a DEPLOY_ACCOUNT transaction has no sender_address, so the field ends up nil.
As-is, any genesis config containing a DEPLOY_ACCOUNT transaction produces a transaction with a nil/zero contract address, which can cause an incorrect or failed genesis block build, or deploy the account at the wrong address
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in genesis/genesis.go at executeTransactions, especially the rpc.TxnDeployAccount branch referenced in the issue, and trace the available DeployAccount transaction fields. Verify the genesis path with a DEPLOY_ACCOUNT transaction; done means the resulting transaction has the correct non-nil contract address and genesis block construction succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100