NethermindEth / NethermindEth/juno
Unexport some of `prune` pkg functions
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 444
- Forks
- 244
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 78
Description
Functions FindOldestBlockAtOrAfter, PrunUpTo and OldestRetainedBlock are public just to be accessible to the pruner_test package.
While it is nice to have this tests, we are following a style where we only test our external API and not our internal API (as much as possible and as long as it makes sense).
Therefore, we should investigate we can un-export this functions and, if necessary, write other test functions that access only the external API and make sure the part of the code touched by this is correct.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the prune package by locating FindOldestBlockAtOrAfter, PrunUpTo, and OldestRetainedBlock, then inspect the pruner_test package to see how they are used. Run the existing prune tests and determine whether external-API tests cover the affected behavior; done means the functions are unexported and the relevant behavior remains tested through the external API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100