Fix compile warnings in mantis-runtime module
Open
@GautamGottipati is already working on this.
Since Mar 30, 2023.
enhancement
good first issue
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 224
- Avg merge
- 22h 46m
- Merged PRs (30d)
- 1
Description
There are compile warnings in the code due to:
- deprecated APIs
- missing
@Nullable/@NotNullannotations - incomplete javadocs
- lambda can be replaced with method references
- raw usage of generic types
- unnecessary type parameters (like
Map<String> m = new HashMap<String>()) - anonymous class can be replaced with lambdas
- ... and more.
We don't need to solve all of them, but a good coding exercise is to address most those compile warnings when possible. Guidelines are:
- Not change code logic, which should be addressed and filed PR separately
- Not change public interfaces (class, methods and fields) that would break other modules or applications. But it's safe to rename private fields or methods when necessary.
- Prefer readability to more concise code
- Improve tests in the module is welcome but not required
- Compile and pass all existing tests.
This tracks the effort for the mantis-runtime module to make the code change scoped. Note this module contains more code than other modules.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.