Get rid of ServiceRegistry::getPropertiesService references in Mantis Codebase
Open
@kriti-sc is already working on this.
Since Feb 27, 2023.
enhancement
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 224
- Avg merge
- 22h 46m
- Merged PRs (30d)
- 1
Description
Context
ServiceRegistry is a singleton instance that holds a reference to MantisPropertiesService. Several components within Mantis use this reference to get certain configuration values at runtime. There are several issues with this approach. Firstly, singletons take a lot of work to manage and test. Secondly, the way the MantisPropertiesService gets loaded is not extendable. We need to consider a more long-term approach to deal with dynamic properties within Mantis. Something like archaius2 might be a good idea.
Goals
- Getting rid of ServiceRegistry.
- Clean ways to integrate with various dynamic config implementations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.