Netflix / Netflix/dgs-codegen

use instanceof in generated code

Open
#701 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
217
Forks
116
PR merge metrics
No merged PRs in 30d

Description

I'm getting this error https://errorprone.info/bugpattern/EqualsGetClass I'll let it explain the rationale.

type IdentityProviderUser {
  identityProviderId: ID!
  externalId: String!
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the generated-code path that handles the IdentityProviderUser GraphQL type and inspect the generated Kotlin equality implementation. Compare the output with the EqualsGetClass rationale, then verify that generated code uses instanceof-compatible type checks and still compiles for the supplied schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, kotlin
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.