Netflix / Netflix/dgs-codegen

why @connection edges is convert to nullable list?

Open
#578 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
217
Forks
116
PR merge metrics
No merged PRs in 30d

Description

It's a trivial question...
https://netflix.github.io/dgs/generating-code-from-schema/#generating-client-apis
when i saw that document
connection type convert to edges like this

type TicksConnection {
    edges: [TickEdge]
}

why is edges always nullable list?
In this way, nodes must be type checked again at the front.
I think like this....

type TicksConnection {
    edges: [TickEdge!]
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked DGS documentation section on generating client APIs and trace how the shown connection schema is produced by the code generator. Confirm whether the nullable edges type is intentional; done means either documenting the rationale or identifying the generator behavior that should change, with a corresponding regression test if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, kotlin
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.