Netflix / Netflix/dgs-codegen

omitNullInputFields does not work

Open
#404 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
217
Forks
116
PR merge metrics
No merged PRs in 30d

Description

Hi all, thanks for all the great work you are doing!

As the generated DSL only generates fields without input fields or with all input fields, we are trying to make use of the omitNullInputFields flag to ensure that we can skip some of them.
Unfortunately it seems that the field omitNullInputFields does not seem to work (anymore?).
A quick search in the codebase does not yield a lot of results either..

Is it still supported?

We are running on the latest versions:

  • graphql-dgs-client: 5.0.3
  • graphql-dgs-codegen-client-core: 5.1.17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the codebase for omitNullInputFields and inspect how graphql-dgs-client 5.0.3 and graphql-dgs-codegen-client-core 5.1.17 handle it. Reproduce the generated DSL behavior with nullable input fields, then establish whether the flag is still supported and what behavior should be considered done.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, kotlin
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.