Netflix / Netflix/dgs-codegen

Do not add redundant "public" word while kotlin code generation from schema

Open
#370 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
217
Forks
116
PR merge metrics
No merged PRs in 30d

Description

Subj.
Example:

import com.fasterxml.jackson.`annotation`.JsonProperty

/**
 * Payload type for contactRequestAdd
 */
public data class ContactRequestAddPayload(
  /**
   * Request status (i.e. successful or not)
   */
  @JsonProperty("status")
  public val status: ContactRequestAddStatus
) {
  public companion object
}

Recommend:

import com.fasterxml.jackson.`annotation`.JsonProperty

data class ContactRequestAddPayload(
  /**
   * Request status (i.e. successful or not)
   */
  @JsonProperty("status")
  val status: ContactRequestAddStatus
) 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Kotlin code-generation entry point or templates that produce visibility modifiers, then compare the generated example with the recommended output. Add regression coverage for the redundant public modifiers and confirm the generated ContactRequestAddPayload no longer includes them.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.