Regression in behaviour of generation in combination with typeMappings [>=4.4.7]
Open
@berngp is already working on this.
Since Jul 22, 2021.
- Dominant language
- Kotlin
- Stars
- 217
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
I found a regression while upgrading codegen from 4.4.6 to the latest 5.0.2 but also 4.4.7 fails.
I have a custom PageInfo type like:
type PageInfo {
hasNextPage: Boolean!
hasPreviousPage: Boolean!
totalCount: Int!
}
used in e.g.:
type EngineManufacturerPage {
items: [EngineManufacturer!]!
pageInfo: PageInfo!
}
and a DGS code generator config for it like:
packageName = "com.mycomp.graphql"
subPackageNameTypes = "type"
generateInterfaces = true
typeMapping = ["PageInfo": "com.mycomp.graphql.type.IPageInfo"]
In 4.4.6 and before above graphqls would generate a IPageInfo like:
public interface IPageInfo {
Boolean getHasNextPage();
Boolean getHasPreviousPage();
Integer getTotalCount();
}
but from 4.4.7 this is not happening anymore unfortunately...
Could it be something changed in the behaviour?
Other interfaces are generated so I suspect the combination with the typeMapping configuration.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.