Netcracker / Netcracker/pgskipper-operator

[Bug]: excessive sleep in patroni_core_controller.go

Open
#162 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
3
Forks
10
Avg merge
2d 3h
Merged PRs (30d)
26

Description

Describe the bug

See https://github.com/Netcracker/pgskipper-operator/blob/6dbb71239d879bfb438151751c0c8e092e85f1f0/operator/controllers/patroni_core_controller.go#L196-L197

The sleep is not documented, and it looks like it spends time without explanation.
At least the code should document the sleep or it should be replaced with a conditional wait.

To Reproduce

See https://github.com/Netcracker/pgskipper-operator/blob/6dbb71239d879bfb438151751c0c8e092e85f1f0/operator/controllers/patroni_core_controller.go#L196-L197

Version

No response

Logs

No response

Additional information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in operator/controllers/patroni_core_controller.go at lines 196-197 and read the surrounding controller flow to understand why the sleep occurs. Determine whether its purpose can be documented or whether the flow needs a conditional wait, then verify that the controller no longer spends unexplained time there and that existing controller behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.