NeogitOrg / NeogitOrg/neogit

Log, Show Signature should only highlight the hash until full commit is displayed

Open
#784 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
5.6k
Forks
357
Avg merge
15h 47m
Merged PRs (30d)
2

Description

Is your feature request related to a problem? Please describe.
I'm not quite sure this is a bug having looked through the code, but it is a usability issue and doesn't function as well as the feature in Magit, in my view. When generating the log with =S "Show Signatures" enabled, the log shows the signature blocks in the table view. Not really helpful, and very cluttered. All you probably need to know in this view is signed / unsigned and good sig / bad sig.

Describe the solution you'd like
This argument should instead pass to the underlying commit fetch for displaying the commit. So the only difference shown on the log page should be that the commit hash is colored, like green instead of grey, indicating a good signature. Then if you actually select the commit <cr> to display, you should see the signature block.

Additional context
Here are some screenshots in Magit showing what I mean.

Screenshot 2023-08-26 at 14 52 52 Screenshot 2023-08-26 at 14 53 26

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the =S “Show Signatures” option from the log view into the underlying commit fetch, then compare the selected-commit display path. Done means the log shows only signature status through hash highlighting while the selected commit still shows its signature block.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, lua, neovim
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.