NeogitOrg / NeogitOrg/neogit

Local 'oid' is nil value during many Neogit actions

Open
#2,009 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.6k
Forks
357
Avg merge
15h 47m
Merged PRs (30d)
2

Description

Description

Whenever I do any of a number of actions in Neogit, I get this error, sometimes twice:

vim.schedule callback: [neogit async] ...ocal/nvim-data/lazy/neogit/lua/neogit/lib/git/bisect.lua:89: attempt to index local 'oid' (a nil value)
stack traceback:
        ...ocal/nvim-data/lazy/neogit/lua/neogit/lib/git/bisect.lua: in function 'fn'
        .../nvim-data/lazy/neogit/lua/neogit/lib/git/repository.lua:254: in function <.../nvim-data/lazy/neogit/lua/neogit/lib/git/repository.lua:252>
stack traceback:
        [C]: in function 'error'
        ...ata/Local/nvim-data/lazy/neogit/lua/neogit/lib/async.lua:277: in function <...ata/Local/nvim-data/lazy/neogit/lua/neogit/lib/async.lua:276>

This happens whenever I run a command in Neogit (like x to discard), open Neogit with the :Neogit command, or unfocus and refocus the Neovim window.

Neovim version

NVIM v0.12.2
Build type: Release
LuaJIT 2.1.1774638290

Operating system and version

Windows 11

Steps to reproduce
  1. nvim -u minimal.lua
  2. :Neogit (Error appears on launch)
  3. Run any command inside neogit (Error appears)
Expected behavior

Doing an action in Neogit performs that action as intended without the pop error.

Actual behavior

The action still gets done, but a popup shows up once or twice in a row with the above error before the action is performed.

Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lua/neogit/lib/git/bisect.lua at line 89 and the callback path in lua/neogit/lib/git/repository.lua around line 252. Use the supplied minimal.lua reproduction, then launch :Neogit and run an action to confirm the nil-value popup no longer appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, lua
Domain
cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.