Log option limit to files fails
Open
Nobody has claimed this yet.
bug
- Dominant language
- Lua
- Stars
- 5.6k
- Forks
- 357
- Avg merge
- 15h 47m
- Merged PRs (30d)
- 2
Description
Description
Trying to use the limit to files option with log currently fails with a stack trace.
Neovim version
NVIM v0.12.0-dev-1326+g35fc4fda99
Build type: RelWithDebInfo
LuaJIT 2.1.1753364724
Run "nvim -V1 -v" for more info
Operating system and version
Arch Linux
Steps to reproduce
- Open
:Neogit logpop up. - Opt for history simplification option
Limit to files. Select any file from your git repo. - Select to log for
currentorHEAD.
Expected behavior
Shows the log pertaining to selected file.
Actual behavior
Lua callback: ...e/pack/core/opt/plenary.nvim/lua/plenary/async/async.lua:18: The coroutine failed with this message: .../pack/core/opt/neogit/lua/neogit/buffers/log_view/ui.
lua:24: attempt to get length of field 'abbreviated_commit' (a nil value)
stack traceback:
[C]: in function 'error'
...e/pack/core/opt/plenary.nvim/lua/plenary/async/async.lua:18: in function 'callback_or_next'
...e/pack/core/opt/plenary.nvim/lua/plenary/async/async.lua:45: in function 'cb'
...re/nvim/site/pack/core/opt/neogit/lua/neogit/process.lua:372: in function <...re/nvim/site/pack/core/opt/neogit/lua/neogit/process.lua:326>
Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}
local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
return base_root_path .. "/" .. (path or "")
end
function M.load_plugin(plugin_name, plugin_url)
local package_root = M.root("plugins/")
local install_destination = package_root .. plugin_name
vim.opt.runtimepath:append(install_destination)
if not vim.loop.fs_stat(package_root) then
vim.fn.mkdir(package_root, "p")
end
if not vim.loop.fs_stat(install_destination) then
print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
vim.fn.system({
"git",
"clone",
"--depth=1",
plugin_url,
install_destination,
})
if vim.v.shell_error > 0 then
error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
vim.log.levels.ERROR)
end
end
end
---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>
---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
vim.opt.packpath = {} -- Empty the package path so we use only the plugins specified
vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir
-- Install required plugins
if plugins ~= nil then
for plugin_name, plugin_url in pairs(plugins) do
M.load_plugin(plugin_name, plugin_url)
end
end
vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
vim.env.XDG_DATA_HOME = M.root("xdg/data")
vim.env.XDG_STATE_HOME = M.root("xdg/state")
vim.env.XDG_CACHE_HOME = M.root("xdg/cache")
-- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
vim.api.nvim_create_autocmd("VimLeave", {
callback = function()
vim.fn.system({
"rm",
"-r",
"-f",
M.root("xdg")
})
end
})
end
-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
plenary = "https://github.com/nvim-lua/plenary.nvim.git",
fzf = 'https://github.com/ibhagwan/fzf-lua',
diffview = "https://github.com/sindrets/diffview.nvim",
neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require('neogit').setup({
integrations = {
diffview = true,
fzf_lua = true,
mini_pick = false,
snacks = false,
telescope = false,
},
sections = {
rebase = {
folded = false,
},
recent = {
folded = false,
},
stashes = {
folded = false,
},
unpulled_pushRemote = {
folded = false,
},
unpulled_upstream = {
folded = false,
},
}
})
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure from the :Neogit log popup using the Limit to files option, then start in lua/neogit/buffers/log_view/ui.lua at the reported abbreviated_commit access and trace the log data through lua/neogit/process.lua. Done means selecting a file and logging current or HEAD displays the corresponding history without a stack trace.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100