NeogitLog: repeating entries
Open
Nobody has claimed this yet.
bug
- Dominant language
- Lua
- Stars
- 5.6k
- Forks
- 357
- Avg merge
- 15h 47m
- Merged PRs (30d)
- 2
Description
Description
After running :NeogitLog, once you have all history loaded, when you type + for "show more history", the log is appended to the existing list.
Neovim version
NVIM v0.11.2
Build type: Release
LuaJIT 2.1.1748459687
Operating system and version
Ubuntu 20.04.6 LTS on WSL2
Steps to reproduce
- Open a file tracked by git
- Run command
:NeogitLog - Ensure all logs are shown
- Note that the prompt for loading more history is still being shown
- Type
+to try and load more anyway - It will start back at the top and output to the log buffer
Expected behavior
- Message to load more is hidden when all history is displayed / reached the end of history
- If attempting to load more, do not append already-loaded history into the list
Actual behavior
- Message to load more is shown when all history has already been loaded
- Loading more after this point adds duplicates to the list
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the :NeogitLog entry point and trace how the + action requests another page after all history is loaded. Verify the end-of-history condition and the list update path; done means the load-more prompt disappears at the end and pressing + does not append duplicate entries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, lua, neovim
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100