NeogitOrg / NeogitOrg/neogit

issue with kind=replace

Open
#1,322 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.6k
Forks
357
Avg merge
15h 47m
Merged PRs (30d)
2

Description

Description

Everytime I go to commit a message I get the following error message if I do anything:

An error occurred.                                                                                                                                                          
.../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:348: Invalid buffer id: 19                                                                                      
stack traceback:                                                                                                                                                            
^I[C]: in function 'nvim_set_option_value'                                                                                                                                  
^I.../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:348: in function 'set_buffer_option'                                                                          
^I.../.local/share/nvim/lazy/neogit/lua/neogit/lib/buffer.lua:330: in function 'unlock'                                                                                     
^I....local/share/nvim/lazy/neogit/lua/neogit/lib/ui/init.lua:634: in function 'update'                                                                                     
^I....local/share/nvim/lazy/neogit/lua/neogit/lib/ui/init.lua:620: in function 'render'                                                                                     
^I...hare/nvim/lazy/neogit/lua/neogit/buffers/status/init.lua:269: in function 'callback'                                                                                   
^I...share/nvim/lazy/neogit/lua/neogit/lib/git/repository.lua:248: in function 'callback'                                                                                   
^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:25: in function 'callback_or_next'                                                                            
^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'saved_callback'                                                                              
^I...are/nvim/lazy/plenary.nvim/lua/plenary/async/control.lua:126: in function 'tx'                                                                                         
^I.../share/nvim/lazy/plenary.nvim/lua/plenary/async/util.lua:67: in function 'callback'                                                                                    
^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:25: in function 'callback_or_next'                                                                            
^I...share/nvim/lazy/plenary.nvim/lua/plenary/async/async.lua:45: in function 'cb'                                                                                          
^I...ami/.local/share/nvim/lazy/neogit/lua/neogit/process.lua:278: in function <...ami/.local/share/nvim/lazy/neogit/lua/neogit/process.lua:244>
Neovim version

NVIM v0.10.0
Build type: Release
LuaJIT 2.1.1713773202

Operating system and version

Linux 6.9.1

Steps to reproduce

Just basic installation thorugh Lazy

Expected behavior

No response

Actual behavior

No error

Minimal config
-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({}) -- For instance, setup Neogit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal configuration and reproduce the error while committing a message. Trace the buffer lifecycle through lua/neogit/lib/buffer.lua:330 and :348, then the render and update paths in lua/neogit/lib/ui/init.lua:620 and :634. Done means the reported commit workflow no longer raises an invalid buffer id error.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.