NebulaSS13 / NebulaSS13/Nebula

Space turfs do not update their ambient light when a dynamically lit turf is created beside them.

Open
#2,746 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
DM
Stars
60
Forks
255
Avg merge
3d 2h
Merged PRs (30d)
77

Description

Description of issue

See title.

Difference between expected and actual behavior

Space turfs only generate/apply ambient light when they are bordering a dynamically lit turf, as otherwise you would have thousands of space turfs pointlessly creating corners etc. However as it stands, they should be updated when a dynamically lit turf is created beside them.

Steps to reproduce
  • Enable starlight.
  • Go to space.
  • Spawn a turf.
  • Put a non-fullbright light source on the turf or nearby.
  • Observe that the edges are dark as though bordering a fulldark turf.
Specific information for locating

I believe this was previously handled in simulated turf init, but not sure.

Length of time in which bug has been known to occur

Presumably since ambient lights were added..

Client version, Server revision & Game ID

Current dev.

Issue bingo
  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by investigating simulated turf initialization, which the issue suggests may have handled ambient-light updates. Reproduce with starlight enabled by spawning a turf in space and placing a non-fullbright light beside it; done means adjacent space turf edges update without requiring a later refresh.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.