NebulaSS13 / NebulaSS13/Nebula

Damage, Oxyloss and welding glass overlays are not applied properly.

Open
#2,190 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs refactor/rewrite
Dominant language
DM
Stars
60
Forks
255
Avg merge
3d 2h
Merged PRs (30d)
77

Description

Description of issue

When you receive a lot of brute damage, a red overlay forms around your screen. Similarly, receiving too much oxygen damage causes your screen to become blacker, and putting on a welding helmet significantly obscures your vision.

Those are all what I am calling 'overlays'. They are not being applied at all in game. The oxygen damage overlay does not work, nor does the red, brute damage overlay. And putting on a welding helmet does not change your vision.

All of those overlays are available at 'icons/mob/screen_full.dmi'

Difference between expected and actual behavior

Overlays should be properly applied when the conditions are met.

Steps to reproduce

Deal yourself a lot of oxygen or brute damage, or wear a welding helmet.
There will be no distortions on your screen view.

Specific information for locating

icons/mob/screen_full.dmi (Where the overlays are stored)
code_onclick\hud\fullscreen.dm (Where some of the overlay code is stored.)
code\modules\mob\living\carbon\human\life.dm - Line 671 (One of the mentions of the fire and brute damage overlay.)

Length of time in which bug has been known to occur

Since an unrelated test in a private server today, 10-30-2021.

Client version, Server revision & Game ID

Client Version: 513
Server Revision: 4a399c669ace3313da76725e724cd818650e8865 - Ahoy,-CMO.-I've-overdosed-on-fentanyl-and-now-I'm-going-to-die - 2021-10-30
Game ID: ceL-cyt8
Current map: ISEO Endeavour

AND

Client Version: 513
Server Revision: 69abc8611e64fccfb6da52435d92181b0be77f58 - ion - 2021-10-30
Game ID: ceL-c8zB
Current map: Tradeship Ocelot Alpha

Issue bingo
  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading code/_onclick/hud/fullscreen.dm and the referenced section around line 671 of code/modules/mob/living/carbon/human/life.dm, then inspect icons/mob/screen_full.dmi. Reproduce the brute-damage, oxygen-damage, and welding-helmet cases and trace why their overlays are not applied. Done means each overlay appears when its stated condition is met.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.