NativeScript / NativeScript/plugins
[@nativescript/biometrics] Android `promptForPin` method checks options for `pinFallBack` instead of `pinFallback`
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 206
- Forks
- 123
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 1
Description
While debugging, we found that in the promptForPin() method in the android code for biometrics, it's checking for the wrong property.
if (!options?.pinFallBack) {
should be
if (!options?.pinFallback) {
NOTE: We can fix it by passing both pinFallBack and pinFallback through on the options, but it would be best if this were fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at packages/biometrics/index.android.ts around line 426 and inspect the promptForPin() options check. Correct the inconsistent fallback property name, then verify that promptForPin() recognizes the documented pinFallback option without requiring the misspelled variant.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, typescript
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100