NativeScript / NativeScript/plugins

[shared-notification-delegate] delegateUniqueKey vs. observerUniqueKey

Open
#119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
206
Forks
123
Avg merge
2d 1h
Merged PRs (30d)
1

Description

The plugin's README.md mentions a delegateUniqueKey, but it should be observerUniqueKey:

https://github.com/NativeScript/plugins/blob/a785b949bd8dcf68f47587d62bfe76e0e6e1960e/packages/shared-notification-delegate/index.d.ts#L2-L7

The v8 documentation also states the wrong key.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Check packages/shared-notification-delegate/README.md and the linked index.d.ts declaration, then compare the corresponding v8 documentation page. Done means both documentation locations consistently use observerUniqueKey instead of delegateUniqueKey.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.