NativeScript / NativeScript/nx

Compatibility with `nx affected` for test / build executors

Open
#32 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
68
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Current behavior

The current setup fails when running the following:

  • nx run {my-app}:build
  • nx affected:build
  • nx affected --target build

Expected Behavior

The above succeed.

Notes

This is partially due to the setup of ios / android targets that pull config from the actual build target, which does not work on its own. This target should be made to work (possibly by invoking a webpack-only build), and then the ios / android targets could invoke it.

If the ios / android targets could consume a webpack-only build, then their executor could use targetDependencies to require the regular build target be hit first, and not have to do a separate webpack build for android and ios.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing nx run {my-app}:build, nx affected:build, and nx affected --target build and inspect the test, build, ios, and android executor configuration. Trace how the ios/android targets consume the regular build target and evaluate the suggested webpack-only build with Nx targetDependencies. Done means all three commands succeed without duplicating the webpack build for ios and Android.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, webpack
Domain
build-system, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.