NativeScript / NativeScript/nativescript-cli

`tns migrate` clears the platforms and next build fails if a custom android runtime was used

Open
#4,877 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

known limitation
Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

If tns migrate was ran on an app with a custom android runtime (tns platform add android --frameworkPath /test/runtime.tgz), next build would fail. This is because the platforms/android folder is deleted and the version of the tns-android package was previously set in the package.json to the literal next version of the runtime. This runtime, of course, couldn't be found in npm and thus the build fails. Couldn't runtimes added with --frameworkPath be handled differently and in some way marked as such in the package.json? Also, couldn't a simple gradlew clean do the dirty work instead of deleting the whole platforms folder?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the tns migrate entry point and its handling of --frameworkPath, then inspect how package.json records the tns-android version and how platforms/android is removed. Compare that behavior with the mentioned gradlew clean option. Done means migrating an app with a custom runtime preserves a usable runtime reference and the next build succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript
Domain
cli, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.