NativeScript / NativeScript/nativescript-cli

[Bundle workflow] VSCode call stack window contains a lot of garbage debugging linked source

Open
#4,813 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os: android os: ios
Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: rc
  • Cross-platform modules: rc
  • Android Runtime: rc
  • iOS Runtime: rc

Describe the bug
Debugging linked tns-core-modules source in VSCode with bundle workflow currently requires us to do it from the top NativeScript folder -- this causes a problem where some of the call stack window entries contain the full filepath thus becoming extremely long (and hiding the essential debugging information). To fix this we have to make the call stack window twice as wide (thus limiting the file listing space)

Screenshot demonstrating the issue (default call stack window width practically shows no meaningful information):
Screenshot 2019-07-05 at 19 45 48

Screenshot demonstrating the workaround:
Screenshot 2019-07-05 at 19 46 22

To Reproduce

  1. git clone git@github.com:NativeScript/NativeScript.git
  2. cd NativeScript
  3. tns create bottom-nav-test --template tns-template-blank-ts
  4. cd bottom-nav-test
  5. tns migrate
  6. Open NativeScript folder in VSCode
  7. Replace the contents of bottom-nav-test/app-root.xml with:
<BottomNavigation>
    <TabStrip>
        <TabStripItem title="First"></TabStripItem>
        <TabStripItem title="Second"></TabStripItem>
    </TabStrip>

    <TabContentItem>
        <GridLayout>
            <Label text="First View" />
        </GridLayout>
    </TabContentItem>

        <TabContentItem>
        <GridLayout>
            <Label text="Second View" />
        </GridLayout>
    </TabContentItem>
</BottomNavigation>
  1. Place a breakpoint in the OnLoaded() method in tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts and a debugger; statement at the beginning of the file
  2. Configure NativeScript debugging and add the following debug configuration in launch.json:
        {
            "name": "bottom-nav | Launch on Android",
            "type": "nativescript",
            "request": "launch",
            "platform": "android",
            "appRoot": "${workspaceRoot}/bottom-nav-test",
            "sourceMaps": true,
            "stopOnEntry": true,
            "watch": true
        },
  1. Debug using the newly added configuration
  2. Breakpoint in OnLoaded() is hit -- see the call stack window

Expected behavior
Call stack window should not display full filepath but only meaningful debug information.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the documented NativeScript CLI steps, the bundle workflow launch configuration, and the breakpoint in tns-core-modules/ui/bottom-navigation/bottom-navigation.android.ts. Inspect the bundle-workflow debugging and source-map handling around the VSCode configuration; done means the call stack shows meaningful entries without unnecessarily long full paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript, typescript, vscode
Domain
cli, developer-experience, mobile-dev, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.