NativeScript / NativeScript/nativescript-cli

Add unit tests for specified areas

Open
#4,423 0 comments 0 reactions 4 assignees View on GitHub

Nobody has claimed this yet.

technical debt
Dominant language
JavaScript
Stars
1.1k
Forks
204
Avg merge
1d 9h
Merged PRs (30d)
8

Description

Is your feature request related to a problem? Please describe.
There are several cases covered by functional tests, which are more suitable for unit tests. Functional tests are much slower, so convert the appropriate ones to unit tests.

Describe the solution you'd like
Have more unit tests for scenarios currently covered with functional tests. Delete the affected functional tests after that. This will speed up the build.

Describe alternatives you've considered
No alternatives.

Additional context
Add unit tests for the following area:

  • Merging of build.xcconfig files:
    • Test scenario with build.xcconfig from plugin/multiple plugins
    • Test scenario with build.xcconfig from App_Resources/iOS
    • Test scenario with build.xcconfig from App_Resources/iOS and from plugins simultaneously

Tests related to work with devices

Tests related to passing invalid platform to commands

Tests related to signing behavior for iOS platform

  • tns run ios --emulator and tns run ios --provision <provision> should rebuild the project
  • tns run ios --provision <provision> and tns run ios --provision <provision> shouldn't rebuild the project
  • tns run ios --emulator and tns run ios --emulator shouldn't rebuild the project

Tests for ios-project-service

  • Adding .framework and .xcframeworks to Xcode project (preparePluginNativeCode)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.